Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #57

Closed
nihgwu opened this issue Mar 21, 2017 · 8 comments
Closed

Carthage support #57

nihgwu opened this issue Mar 21, 2017 · 8 comments

Comments

@nihgwu
Copy link

nihgwu commented Mar 21, 2017

Someone don't want to use CocoaPods to change their project structure, Carthage is a much simpler alternative

@nihgwu nihgwu changed the title **Carthage** support Carthage support Mar 21, 2017
@lelandrichardson
Copy link
Collaborator

@nihgwu thanks for bringing this up. I don't think there is anything actively preventing someone from using Carthage (though I'm not 100% sure). If you can figure this out, I'd love to add some instructions to the docs.

Without trying this myself, I think the main thing is that you might have to install both React and Native Navigation with carthage if you end up doing this, but I'm not sure.

Long term, the right solution might be to get React Native core to also add a dynamic framework target in addition to the static lib target, which I think could solve a lot of these issues.

@benkraus
Copy link
Contributor

Carthage requires an xcodeproj, and a shared scheme, which this currently does not have that I can see. That would be the only thing needed to get Carthage support in, which I'd love to see.

@lelandrichardson any reservations against adding an xcodeproj? I can submit a pull request pretty quickly for this.

@lelandrichardson
Copy link
Collaborator

@benkraus I don't have any problem with this. A PR would definitely be appreciated!

@benkraus
Copy link
Contributor

benkraus commented Mar 29, 2017 via email

@lelandrichardson
Copy link
Collaborator

@benkraus native-navigation is pulled in via cocoapods with a podspec in the example project currently

@benkraus
Copy link
Contributor

Correct me if I am wrong, but from what I can gleam, native-navigation is being developed as a development pod from the example xcodeproj?

@lelandrichardson
Copy link
Collaborator

@benkraus that is correct

@benkraus benkraus mentioned this issue Mar 30, 2017
3 tasks
@emielvanliere
Copy link

Just wondering if anybody got this to work with Carthage already? Thanks!

@nihgwu nihgwu closed this as completed Sep 15, 2017
jahglow pushed a commit to jahglow/native-navigation that referenced this issue Mar 14, 2018
Only set top title if set explicity, otherwise remove it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants