[service_watcher] make sure to check for $EXIT in sleep loop #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we add factory girl to create random checks and services
igor47
force-pushed
the
martin/exit_in_sleep
branch
from
edcd73c
to
dd661b5
Compare
we need a check method, and we add it to possible watchers you can request
we were getting `nil`, not an exception, when the check was not found
this means that rather than assuming the service starts out as down, we explicitly report it as down to begin with
igor47
force-pushed
the
martin/exit_in_sleep
branch
from
dd661b5
to
481c63f
Compare
|
i ended up using this PR as an excuse to add a lot of test coverage. this meant refactoring the |
igor47
added a commit
that referenced
this pull request
Jan 20, 2015
[service_watcher] make sure to check for $EXIT in sleep loop
|
yea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that I describe in:
#54