Change AGP and ddmlib to compileOnly instead of implementation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid pulling a higher version when OkReplay plugin is applied.
|
I don't think this would work since there are breaking changes to the internal AGP APIs that we rely on for version 3.5.0, so moving to |
|
@felipecsl I'm able to build this locally with AGP 3.4.2 and even 3.3.2 and all the tests pass. Our UI tests pass on CI with OkReplay 1.5.0 as well. |
|
hmmm thats surprising since #89 reports exactly the opposite if I understand correctly |
|
oohhh it's a backwards compatible change then 👍 fantastic, thanks for digging! |
felipecsl
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid pulling a higher version of AGP or ddmlib when OkReplay plugin is applied.
I had to change how plugin classpath is provided to tests since the default one supplied by
withPluginClasspath()no longer has AGP in it.Fixes #95
Note that this PR is based on #94.