-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tags in UDP v0 protocol #32
Comments
I like it. Each listener still has a default (at least via the global default) and you can optionally emit to a different topic. 👍 |
@nelgau rewrote the RFC. Care to review? |
Seems reasonable to me! 👍 |
Turned into an enhancement. |
Added bullet point, "Tags from the last processed fragment win; well-behaving clients only set tags on the last fragment to avoid reducing the chunk size or increasing packet count." as discussed with @nelgau. |
I agree with this last bullet point. A correctly-implemented producer should emit consistent headers—whether that means each fragment contains identical tags or, more likely, that only the final message has tags. In both cases, the behavior should be correct. |
Went with a simpler design than originally planned. We might could if performance ever turns out insufficient, but my thinking here is that if a pipeline needs higher perf, it'd be better to create a dedicated listener and avoid using tags altogether. Closes #32.
Went with a simpler design than originally planned. We might could if performance ever turns out insufficient, but my thinking here is that if a pipeline needs higher perf, it'd be better to create a dedicated listener and avoid using tags altogether. Closes #32.
Went with a simpler design than originally planned. We might could if performance ever turns out insufficient, but my thinking here is that if a pipeline needs higher perf, it'd be better to create a dedicated listener and avoid using tags altogether. Closes #32.
Went with a simpler design than originally planned. We might could if performance ever turns out insufficient, but my thinking here is that if a pipeline needs higher perf, it'd be better to create a dedicated listener and avoid using tags altogether. Closes #32.
Went with a simpler design than originally planned. We might could if performance ever turns out insufficient, but my thinking here is that if a pipeline needs higher perf, it'd be better to create a dedicated listener and avoid using tags altogether. Closes #32.
Going with |
byte[][]
inMessage
.The text was updated successfully, but these errors were encountered: