Added be, bs, sh, sr, uk languages #99
Conversation
- add generic Bosnian (`bs`) and Serbian (`sr`) codes According to http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html, Belarussian, Ukrainian, Bosnian, Serbian and Serbian-Croatian languages have the same plural form rules, so it makes sense to add them to the russian plural forms group.
viatsko
changed the title
viatsko
changed the title
|
For Turkish it's trickier as in most of the cases number will remain in a singular form, but if a translation string will be used for, per example, 2 sentences, then there's no chance to set the right form for the 2nd sentence, good example is here http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#tr As putting tr in a correct group wouldn't affect any existing translation tags (as they're singular anyway), I'd suggest keeping the third commit. |
There was a problem hiding this comment.
Thanks! This seems like multiple conceptually different changes all in the same PR, which makes it harder to review:
trmoves from "chinese" to "german"- adding new russian langs
- moving lithuanian from "russian" to its own plural rules
Would you mind peeling out 2 of those 3 changes into separate PRs?
|
Sure, makes sense! Hold on :) |
|
Thanks :-) actually it'd be great if you could reuse this PR for one of the changes :-) Force pushing is always OK! |
|
This one should be good to go, although I can add more tests for the whole family |
viatsko
changed the title
test/index.js
Outdated
| @@ -180,6 +180,69 @@ describe('locale-specific pluralization rules', function () { | |||
| expect(polyglot.t('n_votes', 11)).to.equal('11 صوت'); | |||
| expect(polyglot.t('n_votes', 102)).to.equal('102 صوت'); | |||
| }); | |||
|
|
|||
| it('pluralizes in Belarussian', function () { | |||
There was a problem hiding this comment.
is it "belarussian" or "belorussian"?
There was a problem hiding this comment.
typo, it's "Belarusian" :)
|
Think it makes sense to have tests for all the languages to document the behavior, but tests for these for sure would make a lot of sense to prevent unintended changes. Added! |
|
Squashed |
|
Any plans to merge this one? |
|
@viatsko unfortunately you deleted your repo, so i can't land this; could you please open a new PR? |
According to
http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#lv-comp,
Belarussian and Ukrainian languages have the same plural form rules,
so it makes sense to add them to the russian plural forms group.
Tests for be, ru, uk languages plural forms added to document this behavior.
Closes #94.