Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref prop type #54

Merged
merged 1 commit into from Apr 4, 2019
Merged

Add ref prop type #54

merged 1 commit into from Apr 4, 2019

Conversation

ahuth
Copy link
Contributor

@ahuth ahuth commented Apr 3, 2019

This PR adds a prop type for refs. Both the older callback and the newer createRef styles are supported.

test/ref.jsx Show resolved Hide resolved
src/ref.js Outdated Show resolved Hide resolved
src/ref.js Outdated Show resolved Hide resolved
src/ref.js Outdated Show resolved Hide resolved
test/ref.jsx Show resolved Hide resolved
@ahuth
Copy link
Contributor Author

ahuth commented Apr 4, 2019

@ljharb can you take a look at this again, please?

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i'll rebase this and land/release it ASAP.

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants