Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref prop type #54

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@ahuth
Copy link
Contributor

ahuth commented Apr 3, 2019

This PR adds a prop type for refs. Both the older callback and the newer createRef styles are supported.

Show resolved Hide resolved test/ref.jsx
Show resolved Hide resolved src/ref.js Outdated
Show resolved Hide resolved src/ref.js Outdated
Show resolved Hide resolved src/ref.js Outdated
Show resolved Hide resolved test/ref.jsx
@ahuth

This comment has been minimized.

Copy link
Contributor Author

ahuth commented Apr 4, 2019

@ljharb can you take a look at this again, please?

@ljharb

ljharb approved these changes Apr 4, 2019

Copy link
Member

ljharb left a comment

LGTM, i'll rebase this and land/release it ASAP.

Show resolved Hide resolved README.md Outdated

@ljharb ljharb merged commit 8a55013 into airbnb:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahuth ahuth deleted the ahuth:ref-type branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.