Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving published files #66

Closed
wants to merge 1 commit into from
Closed

Improving published files #66

wants to merge 1 commit into from

Conversation

votemike
Copy link

At the moment prop-types is published with build, src and test directories along with a load of other files in the base directory. I don't believe these are needed and just slow down npm/yarn fetching the package.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very intentional, and they are needed. npm install foo && npm explore foo && npm install && npm test should always work.

Additionally, the “files” property is very dangerous; only .npmignore should be used to prevent publishing of files.

@ljharb ljharb added the wontfix label Sep 18, 2019
@ljharb ljharb closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants