[fix] Make the sync field optional in projectConfig

airbnb · Mar 11, 2019 · 3ac61b4 · 3ac61b4
1 parent 4a794a2
commit 3ac61b4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/src/projectConfig.js b/src/projectConfig.js
@@ -49,7 +49,9 @@ export default {
       type: 'object',
       properties: {
         hooks: { $ref: '#/definitions/require' },
+        additionalProperties: false,
       },
+      required: false,
     },
     rootDir: {
       type: 'string',

diff --git a/test/fixtures/projectConfig.json b/test/fixtures/projectConfig.json
@@ -0,0 +1,8 @@
+{
+  "foo": {
+    "componentsRoot": "./app/assets/javascripts/foo/team/",
+    "components": "./**/*.{jsx,tsx}",
+    "variationsRoot": "./app/assets/javascripts/foo/examples/",
+    "variations": "./**/*VariationProvider.{jsx,tsx}"
+  }
+}
diff --git a/test/helpers/validateProjects.js b/test/helpers/validateProjects.js
@@ -1,4 +1,5 @@
 import validateProjects from '../../src/helpers/validateProjects';
+import testProjectConfig from '../fixtures/projectConfig.json';
 
 describe('validateProjects', () => {
   it('throws when projectNames is not a non-empty array', () => {
@@ -21,4 +22,8 @@ describe('validateProjects', () => {
       message: expect.stringContaining(extraMsg),
     });
   });
+
+  it('should pass on a valid projectConfig', () => {
+    expect(() => validateProjects(testProjectConfig, ['foo'])).not.toThrowError();
+  });
 });