Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Add `aria-roledescription` #1746

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@rcourtie
Copy link

commented Aug 8, 2019

As per the recommendation of the W3C, adding an aria-roledescription to describe the role of the datepicker application. Since this is supposed to be a human-readable and localized description of the element it's passed in through the existing phrases prop, and a default value was included.

Rodolphe Courtier
[a11y] Add `aria-roledescription`
As per the recommendation of the W3C, adding an `aria-roledescription`
to describe the role of the datepicker application. Since this is
supposed to be a human-readable and localized description of the element
it's passed in through the existing phrases prop, and a default value
was included.
@coveralls

This comment has been minimized.

Copy link

commented Aug 8, 2019

Coverage Status

Coverage increased (+0.008%) to 84.895% when pulling 9440e28 on rcourtie:a11y-add-aria-roledescription into 75bba6b on airbnb:master.

@ljharb

ljharb approved these changes Aug 8, 2019

Copy link
Collaborator

left a comment

SGTM, would be good to have some a11y folks confirm

@ljharb ljharb merged commit 7c51390 into airbnb:master Aug 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 84.895%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.