[a11y] Add aria-roledescription
#1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the recommendation of the W3C, adding an `aria-roledescription` to describe the role of the datepicker application. Since this is supposed to be a human-readable and localized description of the element it's passed in through the existing phrases prop, and a default value was included.
ljharb
approved these changes
Aug 8, 2019
backwardok
approved these changes
Aug 9, 2019
|
@rcourtie @backwardok This seems to be failing with axe tests, I am getting the following error:
what's the best way to proceed, should we ignore this tests or remove the label? |
|
@alejandrogarciasalas since it's providing additional information and nothing super crucial (there are additional pieces of information that are also provided to help with what this component is), I think it's ok to ignore that warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the recommendation of the W3C, adding an
aria-roledescriptionto describe the role of the datepicker application. Since this is supposed to be a human-readable and localized description of the element it's passed in through the existing phrases prop, and a default value was included.