SingleDatePicker now re-evaluates isOutsideRange on componentWillReceiveProps

[jlyman]

Fixes #549 by adding a new call to isOutsideRange on componentWillReceiveProps, just like what is being done for isDayBlocked and isDayHighlighted.

[timhwang21]

This might need to account for this.isBlocked() as well, maybe?

[jlyman]

Could you elaborate for me @timhwang21? There are a couple other checks (isDayBlocked() and isDayHighlighted() that happen right afterwards, and I believe this.isBlocked() checks both isDayBlocked and isOutsideRange (on line 628).

[timhwang21]

i have to admit my memory is a bit fuzzy on this now but I believe isBlocked adds its own modifier on top of the others. So you can successfully remove the modifiers for isDayBlocked and isOutsideRange but still have the calendar day blocked. This is what i remember from my own pr, hopefully one of the maintainers can clarify.

[majapw]

What @timhwang21 is saying is we should update this component to look more like what's in the DayPickerRangeController, ie:

if (didFocusChange) {
      values(visibleDays).forEach((days) => {
        Object.keys(days).forEach((day) => {
          const momentObj = moment(day);

          if (this.isBlocked(momentObj)) {
            modifiers = this.addModifier(modifiers, momentObj, 'blocked');
          } else {
            modifiers = this.deleteModifier(modifiers, momentObj, 'blocked');
          }

          if (isOutsideRange(momentObj)) {
            modifiers = this.addModifier(modifiers, momentObj, 'blocked-out-of-range');
          } else {
            modifiers = this.deleteModifier(modifiers, momentObj, 'blocked-out-of-range');
          }

          if (isDayBlocked(momentObj)) {
            modifiers = this.addModifier(modifiers, momentObj, 'blocked-calendar');
          } else {
            modifiers = this.deleteModifier(modifiers, momentObj, 'blocked-calendar');
          }

          if (isDayHighlighted(momentObj)) {
            modifiers = this.addModifier(modifiers, momentObj, 'highlighted-calendar');
          } else {
            modifiers = this.deleteModifier(modifiers, momentObj, 'highlighted-calendar');
          }
        });
      });
    }

[jlyman]

Gotchya... Thanks @majapw and @timhwang21, that makes sense. Let me go ahead and make that improvement.

[majapw]

This looks good! Just the one comment on adding the this.isBlocked => --blocked modifier as well.

[majapw]

Looks great!

[vebits]

Is this feature in v12.1.2?

[jlyman]

@vebjorni I don't believe so, as 12.1.2 was cut seven days ago, and this was merged 4 days ago.

[vebits]

@jlyman Thanks, that makes sense.

@majapw Any idea when the next version will be released?