Add DayPickerSingleDatePicker component
#573
Conversation
|
Fantastic news! I'll check it out very soon, thanks Maja 👏 |
|
This is awesome! Thanks so much! |
|
@ljharb I've added a lot more content to the description to provide context for the changes if you would like to take a look! It does largely just entail moving around a functions that already existed and I do have confidence in the tests catching things. :D |
|
I just switched to this version in our library and replaced the uses of our custom implementation of I just have one question. |
majapw
force-pushed
the
maja-add-daypickersingledatecontroller
branch
from
100d80c
to
5275629
Compare
majapw
force-pushed
the
maja-add-daypickersingledatecontroller
branch
from
5275629
to
7d173c1
Compare
majapw
force-pushed
the
maja-add-daypickersingledatecontroller
branch
from
7d173c1
to
730acf8
Compare
majapw
force-pushed
the
maja-add-daypickersingledatecontroller
branch
from
730acf8
to
229579f
Compare
majapw
force-pushed
the
maja-add-daypickersingledatecontroller
branch
from
229579f
to
48dfbd1
Compare
| } | ||
|
|
||
| componentDidMount() { | ||
| this.isTouchDevice = isTouchDevice(); |
There was a problem hiding this comment.
should this trigger a rerender, if it changes?
| } | ||
|
|
||
| getModifiersForDay(day) { | ||
| return new Set(Object.keys(this.modifiers).filter(modifier => this.modifiers[modifier](day))); |
There was a problem hiding this comment.
should this be new Set(Object.values(this.modifiers).map(x => x(day)))? (using object.values ofc)
(fine as-is, too)
| values(visibleDays).forEach((days) => { | ||
| Object.keys(days).forEach((day) => { | ||
| const momentObj = moment(day); | ||
| if (isDayBlocked(momentObj)) { |
There was a problem hiding this comment.
Whoooops. Man, I knew I should have rebased. :|
There was a problem hiding this comment.
Okay, I think this is back now and released in 12.2.2. D:
Fix for #524
I've created a
DayPickerSingleDateControllerto match theDayPickerRangeControllercomponent. I've also added stories for it as well.The related PR for ranges is #167. The basic gist of this work is that all calendar related code has been moved into an abstraction layer in between the
DayPickerand theSingleDatePickercalled theDayPickerSingleDateController. Specifically this includes the day interaction callbacks (onDayMouseEnter,onDayMouseLeave, andonDayClick) and all code relating to the modifiers.The following graphic should help explain the new structure somewhat (
DayPickerWithRangeControllersmaps to theDayPickerSingleDateController).In a future PR, I will separate out the code related strictly to the input from the
SingleDatePicker. After that theSingleDatePickerwill strictly contain code that coordinates focus and visibility between the input and the calendar dropdown.to: @tagoro9 @pokonski @airbnb/webinfra