Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] deprecate utils/isTouchDevice; use is-touch-device instead #576

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jun 18, 2017

The only part of this that's semver-minor is the deprecation warning; otherwise it's a patch.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Jun 18, 2017
@ljharb ljharb requested a review from majapw June 18, 2017 06:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 86.35% when pulling 2ce7326 on is-touch-device into 4a35a5f on master.

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@majapw majapw merged commit 1a60f68 into master Jun 19, 2017
@majapw majapw deleted the is-touch-device branch June 19, 2017 15:53
@elnazabo
Copy link

Hi,
I think you've missed one usage of the deprecated util, i.e. line 11 in DayPickerSingleDateController.jsx
Could you add a patch for this, for some reason the warning is messing with my Karma tests :P

@ljharb
Copy link
Member Author

ljharb commented Jun 28, 2017

@LillaEli thanks, fixed in 77e2135

devs-cloud pushed a commit to devs-cloud/react-date that referenced this pull request Dec 27, 2019
MarcoAntonioAG added a commit to MarcoAntonioAG/React-dates that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants