Add dayAriaLabelFormat into more places #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erRangeController
majapw
approved these changes
Nov 28, 2017
|
Thanks! |
|
Sorry I'm very late to the game on this! I would think this should also be exposed up through SingleDatePicker and DateRangePicker and noted in the README. As it is right now it's only usable for those using the Controller versions. |
|
@erin-doyle I feel like we ended up doing that in a follow-up somewhere. ... did we not? |
|
I'm not seeing it. I think this PR was the "follow-up" PR to cover exposing this prop up the hierarchy further but I don't think it went far enough. |
@erin-doyle I've made a PR for this! #984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up for #842.
I've added
dayAriaLabelFormatprop intoDayPickerRangeControllerandDayPickerSingleDateControllerto pass the prop toDayPicker.