Add ariaLabelFormat Prop into CalendarDay component #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 14, 2017
| @@ -101,7 +104,7 @@ class CalendarDay extends React.Component { | |||
|
|
|||
| if (!day) return <td />; | |||
|
|
|||
| const formattedDate = { date: `${day.format('dddd')}, ${day.format('LL')}` }; | |||
There was a problem hiding this comment.
hm, is there a reason that it was two separate format calls before?
There was a problem hiding this comment.
I'm not sure... but the result is same.
majapw
approved these changes
Nov 28, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix #778.
I've added
ariaLabelFormatforCalendarDayand added 'dayAriaLabelFormatforCalendarMonth,CalendarMonthGridandDayPickerto pass throughariaLabelFormat`