Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pointerdown #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle pointerdown #18

wants to merge 2 commits into from

Commits on Nov 19, 2018

  1. Handle pointerDown / pointerUp event pairs 

    Unfortunately right now the onOutsideClick will be triggered twice per
click on browsers that support pointer events.
    @joux3
    joux3 committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    5978eb4 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. Remove duplicate triggering of onOutsideClick 

    When both onPointerUp and onMouseUp fire, they will have the same
timeStamp value. Furthermore onPointerUp will always fire before
onMouseUp. Hence if we just handled pointer up and are handling mouse up
caused by the same user event we can just skip it.
    @joux3
    joux3 committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    dd1cdf9 View commit details
    Browse the repository at this point in the history