-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-primitives Touchable doesn't work #104
Comments
Thanks for reporting @tysoncadenhead - looks like we have a fix coming, bear with us 🙏 |
Should be fixed with |
To confirm, it doesn't seem to be fixed in react-primitives@^0.4.3. I'm using CRNA:
lelandrichardson/react-primitives#71 (comment) states that "React 16" isn't compatible yet, but CRNA (and react-native init) only function correctly with React 16+ Any ideas on timings to resolve this? |
Yes. Still not working with 0.4.3. (using CRNA)
|
Could you try with v0.4.4? It's definitely defined here: https://github.com/lelandrichardson/react-primitives/blob/master/src/injection/react-sketchapp.js#L12-L24 |
@mathieudutour is this working on react 16.3? I'm having this same issue using v0.5 and react 16.3 |
First of all, thanks for this awesome project! I'm investigating how this could work at our company to get more client-facing component building in the design team realm and it seems really viable so far!
Now, I may be wrong about the expected behavior, but I thought that all of the react-primitives would work for react-sketchapp. I wouldn't expect Touchable to do anything in sketch, but I was hoping that it would transparently render so I could share components with interactions with the web and native.
When I attempt something like this:
I am getting an error that says:
TypeError: this.touchableGetInitialState is not a function. See the screenshot below:
It works fine when I render it on the web, so it stands to reason this is not an issue with react-primitives. Let me know if I am expecting something that shouldn't work at all, but it seems logical to me that Touchable should at least render and not be interactive in Sketch.
I am using Sketch 43.2 and react-sketchapp 0.10.0
The text was updated successfully, but these errors were encountered: