New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
support transforms #350
support transforms #350
Conversation
Hell yeah! Great work @mathieudutour |
Would you like to see this merged as is (assuming yes as a PR has been opened)? Not sure what type of balance this project wants to strike. Is implementing something better than nothing? Or would we prefer to have a fully baked solution in order to avoid end user confusion? I can give this a set of eyes from a coding standpoint, but I am probably not the right person to speak on philosophy of what should / should not get merged. |
I'm not sure either. I probably won't have time to work on that a lot more (especially because there are tons of edge cases). So I'd say it's easier to get it out there and fix the bug reports afterwards? |
@ljharb Do you mind weighing in quickly with whether or not you agree with merging changes of this nature (incomplete / not fully tested, but still providing value to a certain subset of users)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Transformation works well. Nice move. I just get 4 eslint no-console warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test it deeper this week.
this is awesome, any updates on when we can see this merged? |
hmm, just tested for a bit yesterday and today. seems to not be working with rotates. will test more and follow up with more context |
Has the latest stable version supported transform now |
This reverts commit e6e485d.
fix #14
Only a few transforms are supported:
1
or-1
3D transforms don't work. There are probably bugs when changing the transform origin.
There are tons of edge cases that I haven't tested.