Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deepmerge #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

naoya7076
Copy link

@naoya7076 naoya7076 commented Aug 28, 2020

This package has been outdated. So I updated deepmerge to 3.3.0
I checked all test have passed.

Closes #27.

@naoya7076 naoya7076 mentioned this pull request Aug 28, 2020
@@ -24,7 +24,7 @@
"dependencies": {
"airbnb-prop-types": "^2.10.0",
"brcast": "^2.0.2",
"deepmerge": "^1.5.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merely being outdated is not inherently bad; in this case, why not v4?

Reviewing the changelog suggests that the clone option now defaults to true, which might affect our usage, but otherwise it looks safe.

@micro-chipset
Copy link

micro-chipset commented Sep 28, 2021

@ljharb Please update deepmerge to 4.2.2 #28

@micro-chipset
Copy link

@naoya7076 Please update

@ljharb
Copy link
Collaborator

ljharb commented Oct 7, 2021

The easy breaking changes are that v3 dropped ESM, and v4 dropped UMD - but v2 has some potentially significant breaking changes: https://github.com/TehShrike/deepmerge/blob/master/changelog.md#200 that will take time to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deepmerge is outdated
4 participants