[DirectionProvider] add an inline prop
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inline prop changes the wrapping element to a `<span>` instead of a `<div>`. This can be used when setting the direction context of inline elements, to avoid inserting a block level element.
|
@yzimet LGTM! Oh I don't have write access. Regrettable. |
ljharb
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inlineprop of DirectionProvider changes the wrapping element to a<span>instead of a<div>. This can be used when setting the direction context of inline elements, to avoid inserting a block level element.to: @garrettberg @jasonkb @ljharb @airbnb/react-with-direction-maintainers