Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Align peer and prod dependencies #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tombrowndev
Copy link

Peer dependency for react-with-direction is at a different version than the packages own dependency, causing unmet dependency warnings when installed.

Peer dependency for react-with-direction is at a different version than the packages own dependency, causing unmet dependency warnings when installed.
package.json Outdated
@@ -74,7 +74,7 @@
},
"peerDependencies": {
"react": ">=0.14",
"react-with-direction": "^1.1.0"
"react-with-direction": "^1.3.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this is a breaking change; we should lower the runtime version to 1.1 instead.

@ljharb
Copy link
Collaborator

ljharb commented Feb 19, 2019

Note, though, that 1.3 is valid against ^1.1, so there should be no warnings.

@tombrowndev
Copy link
Author

@ljharb
Ok, maybe its my own configuration, but I get this warning on install:
"rheostat > react-with-styles@3.2.1" has unmet peer dependency "react-with-direction@^1.1.0".
and i thought this was the correct fix.

This aligns with the peer dependency version
@ljharb
Copy link
Collaborator

ljharb commented Feb 19, 2019

what does rheostat declare for react-with-direction, and what version do you have installed anywhere else in your graph?

@tombrowndev
Copy link
Author

It doesn't. The only package that references react-with-direction in my yarn.lock is react-with-styles.

@ljharb
Copy link
Collaborator

ljharb commented Feb 20, 2019

hmm, i'd expect react-with-direction to get hoisted to the top, and any version v1.1.0 or higher, that's lower than v2, should satisfy the peer dep warning. This might be a yarn bug - it has quite a number of peerDep-related bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants