New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Align peer and prod dependencies #207
base: master
Are you sure you want to change the base?
Fix: Align peer and prod dependencies #207
Conversation
Peer dependency for react-with-direction is at a different version than the packages own dependency, causing unmet dependency warnings when installed.
package.json
Outdated
@@ -74,7 +74,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"react": ">=0.14", | |||
"react-with-direction": "^1.1.0" | |||
"react-with-direction": "^1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this is a breaking change; we should lower the runtime version to 1.1 instead.
Note, though, that 1.3 is valid against ^1.1, so there should be no warnings. |
@ljharb |
This aligns with the peer dependency version
what does rheostat declare for react-with-direction, and what version do you have installed anywhere else in your graph? |
It doesn't. The only package that references react-with-direction in my yarn.lock is react-with-styles. |
hmm, i'd expect |
Peer dependency for react-with-direction is at a different version than the packages own dependency, causing unmet dependency warnings when installed.