[breaking][deps] Update all dependencies and drop support for node < 6 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had started this here, not sure if there's anything helpful for you there: #212 |
lencioni
approved these changes
Aug 7, 2019
noratarano
commented
Aug 7, 2019
package.json
Outdated
| "@babel/register": "^7.5.5", | ||
| "airbnb-js-shims": "^2.2.0", | ||
| "babel-plugin-transform-replace-object-assign": "^2.0.0", | ||
| "babel-preset-airbnb": "^3.3.2", |
There was a problem hiding this comment.
Oooh! There's a version 4!
https://github.com/airbnb/react-with-styles/pull/212/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R54
Suggested change
| "babel-preset-airbnb": "^3.3.2", | |
| "babel-preset-airbnb": "^4.0.0" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update all dependencies. We also drop support for
nodeversions 4 and 5 since babel dropped support for them inbabel@7.Note: This is step 1 in a list of TODOs that I have for refactoring this library to not use singletons. While these updates are not necessary, they keep the repo modernized.
Update:react-with-stylesdeps[breaking][deps] Update all dependencies and drop support for node < 6 #219
Update:react-with-styles-interface-aphroditedeps[deps] Update all deps and drop support for node < 6 react-with-styles-interface-aphrodite#65
react-with-stylesto use styles interface and theme in contextreact-with-styles v4.0.0react-with-styles-interface-aphroditepeer dep version forreact-with-stylesreact-with-styles-interface-aphrodite v6.0.0Testing
npm run buildandnpm run testusingnode@8.9.1andnpm@6.9.0with successnodeandnpmthat we support@brucewpaul @goatslacker
@ljharb @lencioni