Move the hooks implementation to its own HOC and re-implement withStyles with context as a class component #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 28, 2019 20:23
Also restore the caching of stylesFn(theme) results per component and add direction to the WithStylesContext.
- Theme and Interface providers help with amending the existing context with new values - Direction adapter helps provide the direction provided by react-with-direction
Have to remove the contextType the withDirection component hoists because it's using an old version of hoist-non-react-statics that copies it over
noratarano
force-pushed
the
nora--with-styles-with-context
branch
from
3eca4d7
to
86598fb
Compare
ljharb
approved these changes
Aug 29, 2019
noratarano
added
semver-patch: fixes etc
and removed
semver-major: breaking change
labels
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
withStylesFunctionalwithStyleswith context as a class component to make a more equivalent API swap to continue supporting implied and legacy refs on the HOC.directionto theWithStylesContextso we can usecontextType, and provide aWithStylesDirectionAdapteras a helper to take the direction provided byreact-with-directionand add it toWithStylesContext. Also adds helper providers to amend the values in context for the other values.Testing
Followup
Reviewers
@ahuth @TaeKimJR @ljharb @indiesquidge