-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking][deps] Add @babel/runtime as a peer dep #229
Conversation
package.json
Outdated
@@ -50,6 +50,7 @@ | |||
"@babel/cli": "^7.5.5", | |||
"@babel/core": "^7.5.5", | |||
"@babel/register": "^7.5.5", | |||
"@babel/runtime": "^7.5.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally the dev dep version is an exact match of the peer dep one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb The issue is that eslint-plugin-jsx-a11y@6.2.3
installs 7.5.5. 🤔 so it always resolves to 7.5.5 anyway. Should we require the peer dep to be 7.5.5 or 7.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but ^7 will include that too. I think ^7 is the most widely compatible.
29cfb26
to
eb70346
Compare
eb70346
to
1ed04bd
Compare
@@ -76,6 +77,7 @@ | |||
"sinon-sandbox": "^2.0.5" | |||
}, | |||
"peerDependencies": { | |||
"@babel/runtime": "^7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb Now the versions of @babel/runtime
are set to ^7.0.0
and they match! PTAL 🙏
Summary
Was getting the following error from another repo that didn't have it installed while I was testing version
4.0.0-alpha.1
:We need to add it because
@babel/runtime
is a peer dep ofbabel-preset-airbnb
. The reason we weren't seeing any errors for this before is becauseeslint-plugin-jsx-a11y
(a dev dep here) had already installed it as a dependency.Reviewers
@ljharb @lencioni @TaeKimJR @indiesquidge @ahuth @joeuy @majapw