[performance] Cache by the resulting WithStyles HOC
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2019 18:17
Cache by WithStyles component so that we avoid unnecessarily calling the create function of aphrodite.
noratarano
force-pushed
the
nora--memoize-more
branch
from
fbb49c4
to
1f0454f
Compare
ljharb
reviewed
Oct 18, 2019
esprehn
reviewed
Oct 18, 2019
noratarano
force-pushed
the
nora--memoize-more
branch
from
f560516
to
e1d3671
Compare
ljharb
approved these changes
Oct 19, 2019
src/withStyles.jsx
Outdated
| getCurrentInterface() { | ||
| // Fallback to the singleton implementation | ||
| return (this.context && this.context.stylesInterface) || _getInterface(); | ||
| return ( | ||
| (this.context && this.context.stylesInterface) || _getInterface() |
There was a problem hiding this comment.
nbd ofc but this change seems surprising. is your editor running more than eslint autofix on things?
There was a problem hiding this comment.
@ljharb You're right this is weird, lol. I have some weird linting/prettier/editor autofix stuff going on 🤦♀ I tried fixing it but it's still giving me things like this.
There was a problem hiding this comment.
Generally the only formatting you want enabled is eslint autofix - ie, in vscode, disable "format on save", and prettier, and be sure you don't have any global eslint installed (so it always uses the local one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cache even further by the resulting
WithStylescomponent so that we avoid calling create/resolve unnecessarily per component instance. Before, we were calling create once per theme, per component instance, per direction. This way, we're calling create once per theme, per component definition, per direction, which should happen less often.We also refactor some class methods that didn't need to be class methods
I would especially appreciate feedback around the organization of this code for performance and clarity. Take a look at the commits for easy of review.
Reviewers
@esprehn @TaeKimJR @joeuy @indiesquidge @ljharb @marsjosephine