Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropType warnings for not required props #288

Open
daryaskopyuk opened this issue Nov 30, 2021 · 1 comment
Open

PropType warnings for not required props #288

daryaskopyuk opened this issue Nov 30, 2021 · 1 comment

Comments

@daryaskopyuk
Copy link

daryaskopyuk commented Nov 30, 2021

In the latest version of rheostat I receive prop type warnings for not required props that are not passed to <Rheostat /> component. These props are: handle, background, progressBar.

For example, for the component...

<RangeSlider
   min={0}
   max={100}
   values={[min, max]} 
   snap={true}
/>

...there are warnings like this:
Screenshot 2021-11-29 at 10 09 50

As far as we investigated this issue, these warnings appear when react-with-styles dependency has version 4.2.0. When we pin it to 4.1.0 warnings are not present.

@ljharb
Copy link
Collaborator

ljharb commented Dec 1, 2021

cc @noratarano @lencioni; v4.2.0 of react-with-styles caused breaking changes in react-dates, and appears to be doing the same here. can someone look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants