Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rubocop 0.59.1 #146

Closed
stephane-rbn opened this issue Sep 23, 2018 · 8 comments
Closed

Upgrade to rubocop 0.59.1 #146

stephane-rbn opened this issue Sep 23, 2018 · 8 comments

Comments

@stephane-rbn
Copy link

Since the version 0.59.1 of rubocop has been released, is there any plan to upgrade to it?

It's not a big issue but I'm still getting some conflicts because of the version 0.57.2 used by rubocop-airbnb.

I'm still a newbie to code but I can help if you tell me what to do to upgrade the dependency version. I guess we should do something like this. As a junior ruby developer, I would be very happy to help.

@robotpistol
Copy link
Contributor

Hi @stephanyan thank for your interest. Currently our main ruby repository is still locked at ruby 2.1.8. After rubocop version 0.57.2 they dropped support for ruby < 2.2. I will get around to upgrading things but that is the main reason i haven't upgraded things already.

@stephane-rbn
Copy link
Author

I see. Thanks for your reply @robotpistol, it makes sense (ruby 2.1.8 though!).

@robotpistol
Copy link
Contributor

robotpistol commented Oct 11, 2018

Yeah... 2.1.8 indeed 😆 😭

@stephane-rbn
Copy link
Author

Hi there! Still no plan to update this gem? Do Airbnb developers still use this style guide (at least all cops) to code? 😆

@ljharb
Copy link
Contributor

ljharb commented Apr 8, 2019

Still no change; we will use it fully.

@stephane-rbn
Copy link
Author

@ljharb Sorry, what do you mean?

@ljharb
Copy link
Contributor

ljharb commented Apr 9, 2019

@stephanyan you asked two questions: Still no plan? correct, still no plan. Do Airbnb devs still use this guide and all cops? Yes.

@zachsabin
Copy link
Collaborator

Master branch is now updated to 0.76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants