Make PagerDuty output idempotent; adds support for responder requests (…

…#935) * Alot of changes but requires testing * i funcional 2nd iteration * More fixupes * More improvements * oh god i have so many tests to fix * Fixup more tests * Awesome improvements * Fixes the tests * fixup * Further improves tests and test coverage * Improve test coverage * yep * Coveregae * mgaoebfalwkejlk * More test coverage
airbnb · May 7, 2019 · f1cf85c · f1cf85c
1 parent 4baf713
commit f1cf85c
Show file tree

Hide file tree

Showing 3 changed files with 1,071 additions and 788 deletions.
diff --git a/stream_alert/alert_processor/outputs/output_base.py b/stream_alert/alert_processor/outputs/output_base.py
@@ -43,6 +43,10 @@
 class OutputRequestFailure(Exception):
     """OutputRequestFailure handles any HTTP failures"""
 
+    def __init__(self, response):
+        super(OutputRequestFailure, self).__init__()
+        self.response = response
+
 
 def retry_on_exception(exceptions):
     """Decorator function to attempt retry based on passed exceptions"""
@@ -222,7 +226,7 @@ def do_put_request():
             resp = cls._put_request(url, params, headers, verify)
             success = cls._check_http_response(resp)
             if not success:
-                raise OutputRequestFailure()
+                raise OutputRequestFailure(resp)
 
             return resp
         return do_put_request()
@@ -263,7 +267,7 @@ def do_get_request():
             resp = cls._get_request(url, params, headers, verify)
             success = cls._check_http_response(resp)
             if not success:
-                raise OutputRequestFailure()
+                raise OutputRequestFailure(resp)
 
             return resp
         return do_get_request()
@@ -304,7 +308,7 @@ def do_post_request():
             resp = cls._post_request(url, data, headers, verify)
             success = cls._check_http_response(resp)
             if not success:
-                raise OutputRequestFailure()
+                raise OutputRequestFailure(resp)
 
             return resp
         return do_post_request()