Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes a default option that is breaking deploys #1195

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

Ryxias
Copy link
Contributor

@Ryxias Ryxias commented Mar 17, 2020

to: @ryandeivert @chunyong-lin @blakemotl
cc: @airbnb/streamalert-maintainers

Background

This default option actually breaks deploys because it provides the name of an existing logging bucket that is invalid.

Notably, this is already documented here: https://www.streamalert.io/en/release-3-0-0/config-global.html#s3-access-logging

@Ryxias Ryxias changed the base branch from master to release-3-0-0 March 17, 2020 19:15
@Ryxias Ryxias added the bug label Mar 17, 2020
@Ryxias Ryxias added this to the 3.0.0 milestone Mar 17, 2020
Copy link
Contributor

@ryandeivert ryandeivert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just remove the full block s3_access_logging block? it has sane defaults and is not needed here. docs outline the settings well if users want to use it

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.893% when pulling 266f2fd on dw--fixupthing into 319fc11 on release-3-0-0.

@Ryxias Ryxias merged commit f8379ef into release-3-0-0 Mar 17, 2020
@Ryxias Ryxias deleted the dw--fixupthing branch March 17, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants