Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] adding scheduled queries iam role path prefix #1216

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[bug] adding scheduled queries iam role path prefix #1216

merged 1 commit into from
Mar 31, 2020

Conversation

ryandeivert
Copy link
Contributor

@ryandeivert ryandeivert commented Mar 31, 2020 •
edited

to: @airbnb/streamalert-maintainers

Background

The IAM roles used by the scheduled queries service were not properly using the /streamalert/ path prefix

Changes

  • Updating role path prefix.
  • Adding tags to resources that support them.
  • Removing unnecessary versions.tf file.

@ryandeivert ryandeivert added terraform streamquery Scheduled queries labels Mar 31, 2020
@ryandeivert ryandeivert added this to the 3.1.1 milestone Mar 31, 2020
@ryandeivert ryandeivert changed the base branch from master to release-3-1-1 March 31, 2020 18:39
@ryandeivert ryandeivert changed the title scheduled queries iam role path fix [bug] scheduled queries iam role path fix Mar 31, 2020
@ryandeivert ryandeivert changed the title [bug] scheduled queries iam role path fix [bug] adding scheduled queries iam role path prefix Mar 31, 2020
@coveralls
Copy link

coveralls commented Mar 31, 2020 •
edited

Coverage Status

Coverage remained the same at 95.428% when pulling 87542e1 on ryandeivert-sq-role-path-fix into 5b63c95 on release-3-1-1.

Ryxias
Ryxias approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@Ryxias Ryxias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whomp whomp :(

@ryandeivert ryandeivert merged commit 07812ef into release-3-1-1 Mar 31, 2020
@ryandeivert ryandeivert deleted the ryandeivert-sq-role-path-fix branch March 31, 2020 19:14
ryandeivert added a commit that referenced this pull request Mar 31, 2020
@ryandeivert @Ryxias
official release of v3.1.1 (#1215)
1714b1e 
* bumping version to 3.1.1

* fixing bad links in docs, other touch ups (#1214)

* DRY out some code

* fix

* updating role paths used by scheduled queries (#1216)

Co-authored-by: Derek Wang <derek.wang@airbnb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryxias Ryxias Ryxias approved these changes

Assignees
No one assigned
Labels
streamquery Scheduled queries terraform
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryandeivert @coveralls @Ryxias