Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

official release of v3.1.2 #1219

Merged
merged 3 commits into from
Apr 2, 2020
Merged

official release of v3.1.2 #1219

merged 3 commits into from
Apr 2, 2020

Conversation

ryandeivert
Copy link
Contributor

to: @airbnb/streamalert-maintainers

Background

Reason for the change

Changes

  • Fixes a bug in scheduled_queries terraform module generation related to s3 buckets as map vs list.
  • Fixes bug in naming convention of athena results bucket (hypens vs periods as delimiter)
  • DRY out some code in athena generation code.

Testing

Adding unit tests for schedule queries terraform module generation.

@ryandeivert ryandeivert added this to the 3.1.2 milestone Apr 1, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.43% when pulling c98a66b on release-3-1-2 into 1714b1e on master.

Ryxias
Ryxias approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@Ryxias Ryxias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing tests where I was lazy and failed to do so

@ryandeivert ryandeivert merged commit 41da6b5 into master Apr 2, 2020
@ryandeivert ryandeivert deleted the release-3-1-2 branch April 9, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryxias Ryxias Ryxias approved these changes

@chunyong-lin chunyong-lin chunyong-lin approved these changes

Assignees
No one assigned
Labels
athena bug streamquery Scheduled queries
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryandeivert @coveralls @Ryxias @chunyong-lin