Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three custom metrics #1246

Merged
merged 1 commit into from
May 11, 2020

Conversation

chunyong-lin
Copy link
Contributor

to: @airbnb/streamalert-maintainers
related to:
resolves:

Background

Add three custom metrics for Artifact Extractor

  1. ArtifactExtractor-ExtractedArtifacts: Log the number of artifacts extracted from the records
  2. ArtifactExtractor-FirehoseFailedRecords: Log the number of records (artifacts) failed sent to Firehose
  3. ArtifactExtractor-FirehoseRecordsSent: Log the number of records (artifacts) sent to Firehose

These three custom metrics are useful for tracking the metrics of artifacts by adding them to a CloudWatch dashboard, as well as helpful to set alarms if necessary.
artifact_extractor_custom_metrics

Changes

  • Allow to pass function_name to custom metrics
  • Add three custom metrics for Artifact Extractor
  • Update unit test cases
  • Update docs

Testing

Steps for how this change was tested and verified

@chunyong-lin chunyong-lin merged commit 08725d1 into feature-artifact-extractor May 11, 2020
@chunyong-lin chunyong-lin deleted the cylin-ae-custom-metrics branch May 11, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants