Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding fix for #1294 to only copy terraform files once during init #1295

Merged
merged 2 commits into from Oct 5, 2020
Merged

adding fix for #1294 to only copy terraform files once during init #1295

merged 2 commits into from Oct 5, 2020

Conversation

ryandeivert
Copy link
Contributor

to @airbnb/streamalert-maintainers
cc @blakemotl
resolves #1294

Background

See #1294

Changes

  • Ensuring copy of terraform files happens only once during init.. instead of attempting multiple times throughout the process.

Other Changes

  • Defaulting athena settings to parquet and removing prior warning.

Testing

Updates to unit tests

@ryandeivert ryandeivert added this to the 3.4.1 milestone Oct 5, 2020
chunyong-lin
chunyong-lin approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@chunyong-lin chunyong-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment unrelated to the issue you fix for terraform init.

streamalert_cli/terraform/generate.py Show resolved Hide resolved
@chunyong-lin chunyong-lin mentioned this pull request Oct 5, 2020
Open
@ryandeivert ryandeivert merged commit 2653cc0 into release-3-4-1 Oct 5, 2020
@ryandeivert ryandeivert deleted the ryandeivert-fix-1294 branch October 5, 2020 19:34
ryandeivert added a commit that referenced this pull request Oct 5, 2020
@ryandeivert
official release of v3.4.1 (#1297)
27b8669 
* bumping version to 3.4.1

* adding fix for #1294 to only copy terraform files once during init (#1295)

* adding fix for #1294

* pylint
@ryandeivert ryandeivert mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunyong-lin chunyong-lin chunyong-lin approved these changes

Assignees
No one assigned
Labels
cli deployment terraform
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryandeivert @chunyong-lin