Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random_bool helper function #756

Merged
merged 2 commits into from May 30, 2018
Merged

Add random_bool helper function #756

merged 2 commits into from May 30, 2018

Conversation

austinbyers
Copy link
Contributor

to: @strcrzy
cc: @airbnb/streamalert-maintainers
size: small

Background

For rules which are very noisy, it may be helpful to return only a sample of the true positives.

Changes

  • Add a random_bool base helper function

Testing

  • Unit tests and pylint

@austinbyers austinbyers requested a review from strcrzy May 30, 2018 20:55
strcrzy
strcrzy approved these changes May 30, 2018
View reviewed changes
Copy link
Collaborator

@strcrzy strcrzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.595% when pulling 02a39ff on austin-base-helpers into b8ef603 on master.

@austinbyers austinbyers merged commit aec1cfd into master May 30, 2018
@austinbyers austinbyers deleted the austin-base-helpers branch May 30, 2018 21:32
@ryandeivert ryandeivert added this to the 2.0.0 milestone Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strcrzy strcrzy strcrzy approved these changes

Assignees
No one assigned
Labels
helpers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinbyers @coveralls @strcrzy @ryandeivert