This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[sql] Using read_sql_query instead of read_sql (#4853) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8934717)
|
LGTM |
|
How is my LGTM still not effective? |
|
Oh, it fails CI |
Codecov Report
@@ Coverage Diff @@
## airbnb-master #41 +/- ##
==============================================
Coverage 71.14% 71.14%
==============================================
Files 188 188
Lines 14849 14849
Branches 1085 1085
==============================================
Hits 10564 10564
Misses 4282 4282
Partials 3 3
Continue to review full report at Codecov.
|
timifasubaa
approved these changes
Apr 23, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
#41) * [typescript] add build support for typescript * [typescript] working lint and build * [typescript] refactor SupersetClient to TS * [typescript][connection] leverage RequestInit types when relevant * [typescript][connection] callApi.js => callApi.ts * [typescript][connection] remaining .js => .ts * [typescript][connection] add and export src/types.ts, refactor things, convert test to .ts and fix * [typescript] build:ts only in typescript-containing packages
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8934717)
to: @graceguo-supercat @michellethomas @timifasubaa