fix timestamp error in table view #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
previously requested changes
Jan 12, 2017
|
@xrmx hi, i found only one place that used simplejson in view.py, that's line 1408 where i modified the code. so i deleted this module in this file. |
mistercrunch
dismissed
xrmx’s stale review
@flametest is right, that line can be removed
|
I meant just for consistency wrt other superset code, i agree we should just use json and drop simplejson dependency altogether. |
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1934, using iso serializer instead of int serializer in table view.