Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in displaying query text #2006

Closed
wants to merge 3 commits into from
Closed

Conversation

flametest
Copy link
Contributor

component ExploreActionButtons got only two parameters from explore.jsx instead of three. so the query pop-up window will show nothing whether it succeeds or not.

1

and we just get query from slice.data.

@bkyryliuk
Copy link
Member

@ascott ^^

@ascott
Copy link
Contributor

ascott commented Jan 31, 2017

thanks for your contribution @flametest!

this fixes the bug in explore V1 but breaks it in explore V2.

you can test explore-v2 by adding &V2=true to the slice url or you can create a role called explore-v2-beta and add your user to that role.

can you revise so this works in both v1 and v2?

@vera-liu
Copy link
Contributor

This should work for both v1 and v2 #2080

@ascott ascott closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants