Clarify Rule: Use caseless enums for organizing public or internal constants and functions into namespaces.

[teddy5518]

Summary

I adjusted two rules's wording, Use caseless `enum`s for organizing `public` or `internal` constants and functions into namespaces and Bind to `self` when upgrading from a weak reference, to reduce confusion.

Reasoning

Bind to `self` when upgrading from a weak reference's example of wrongdoing contains do work key word which confuses if the example is right or wrong. Use caseless `enum`s for organizing `public` or `internal` constants and functions into namespaces was not stating if the case was wrong or right, so I thought adding RIGHT keyword increase readability of the example.

Please react with 👍/👎 if you agree or disagree with this proposal.

[calda]

I'm not sure why we would remove this, considering:

1. the example below includes it as well
2. this is a placeholder that implies the closure contains more code than just completion(). If the closure truly just called completion() immediately then unwrapping self would be unnecessary, making the example redundant

[teddy5518]

After reading your comment, I could understand the true usage of '// Do work'. I will revert change accordingly. Thank you for explaining on this.

[calda]

I'm not sure we need this here -- I think it's clear from the context since there's only a single example for this rule. If we added an incorrect example (e.g. using struct instead of enum) I could see why we would want to include the // RIGHT and // WRONG comments.

[teddy5518]

As my purpose of PR was to increase readability, I agree that providing struct usage of incorrect example could be better. Then may I add below as incorrect examples?

struct Environment {
  static let earthGravity = 9.8
  static let moonGravity = 1.6
}

struct Environment {

  struct Earth {
    static let gravity = 9.8
  }

  struct Moon {
    static let gravity = 1.6
  }
}

[calda]

Sure, that example would be incorrect based on this rule

[teddy5518]

Thank you for sharing thoughts. I made adjustment accordingly.