Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: ignore Rule OpenSource Library #219

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Update: ignore Rule OpenSource Library #219

merged 2 commits into from
Mar 31, 2023

Conversation

interactord
Copy link
Contributor

Summary

I have added code to two source files excluding external libraries such as Carthage, Pods, and SourcePackages (SPM).

Reasoning

I added code to enforce the Airbnb style rules only on the code we wrote, as I believe it is the intended behavior to apply the rules only to our own code when using the command "swiftFormat .", which also modifies external libraries.

Please react with 馃憤/馃憥 if you agree or disagree with this proposal.

@interactord
Copy link
Contributor Author

In the previous PR, I attempted to remove the SourcePackages file from the lint. However, upon reviewing the FastFile code again, I realized that SourcePackages was a custom name used in my project for caching SPM libraries in fastlane.

Therefore, I decided that this was not a part to request changes for in the PR and made the necessary modifications before committing again. Additionally, I believe it would be a good idea to explicitly specify external libraries not only in SwiftLint but also in swiftFormat.

Furthermore, the .build folder is generated by the swift package build command and does not require linting, so I made additional modifications to update the source accordingly.

Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calda calda merged commit ba02057 into airbnb:master Mar 31, 2023
@interactord interactord deleted the PR branch April 1, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants