Add rule to add a linebreak before the else keyword in a multi-line guard statement #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a new rule to add a linebreak before the else keyword in a multi-line guard statement.
Reasoning
This was first suggested back in #108 (comment). This is also how the examples in the "wrap multi-line conditionals" rule description are formatted.
Placing the
else
on its own line makes it more visually distinct, and prevents it from blending in with the last statement.We previously didn't enforce this through the formatter since the SwiftFormat rule for this didn't match our requirements very well. As of nicklockwood/SwiftFormat#1447 the SwiftFormat rule implementation works well for us.
Please react with 👍/👎 if you agree or disagree with this proposal.