Fix issue where linter would disallow "@unchecked Sendable" string in comments #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Sep 25, 2023
| @@ -55,5 +55,8 @@ custom_rules: | |||
| no_unchecked_sendable: | |||
| name: "`@unchecked Sendable` is discouraged." | |||
| regex: "@unchecked Sendable" | |||
| match_kinds: | |||
| - attribute.builtin | |||
| - typeidentifier | |||
There was a problem hiding this comment.
Determined this by using the command recommended in the SwiftLint documentation:
$ sourcekitten syntax --text "extension Foo: @unchecked Sendable { }"
[
{
"length" : 9,
"offset" : 0,
"type" : "source.lang.swift.syntaxtype.keyword"
},
{
"length" : 3,
"offset" : 10,
"type" : "source.lang.swift.syntaxtype.typeidentifier"
},
{
"length" : 10,
"offset" : 15,
"type" : "source.lang.swift.syntaxtype.attribute.builtin"
},
{
"length" : 8,
"offset" : 26,
"type" : "source.lang.swift.syntaxtype.typeidentifier"
}
]
There was a problem hiding this comment.
I was wondering how SwiftLint handled the fact that @unchecked Sendable matches both attribute.builtin and syntaxtype.typeidentifier. This seems like the answer.
bachand
reviewed
Sep 26, 2023
| @@ -55,5 +55,8 @@ custom_rules: | |||
| no_unchecked_sendable: | |||
| name: "`@unchecked Sendable` is discouraged." | |||
| regex: "@unchecked Sendable" | |||
| match_kinds: | |||
| - attribute.builtin | |||
| - typeidentifier | |||
There was a problem hiding this comment.
I was wondering how SwiftLint handled the fact that @unchecked Sendable matches both attribute.builtin and syntaxtype.typeidentifier. This seems like the answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the linter would not allow you to use the string
@unchecked Sendablein a comment.This was previously disallowed by the linter, because the regex matched the
"@unchecked Sendable"text in the comment:but is now allowed as expected