new(localPoint, localPointGeneric): return null for empty events

airbnb · Oct 22, 2019 · e5a0c80 · e5a0c80
1 parent c2a1a50
commit e5a0c80
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/vx-event/src/localPoint.ts b/packages/vx-event/src/localPoint.ts
@@ -1,4 +1,3 @@
-import { Point } from '@vx/point';
 import localPointGeneric from './localPointGeneric';
 import { EventType } from './types';
 import { isElement, isEvent } from './typeGuards';
@@ -11,5 +10,5 @@ export default function localPoint(nodeOrEvent: Element | EventType, maybeEvent?
     const node = nodeOrEvent.target as Element;
     if (node) return localPointGeneric(node, nodeOrEvent);
   }
-  return new Point({ x: 0, y: 0 });
+  return null;
 }
diff --git a/packages/vx-event/src/localPointGeneric.ts b/packages/vx-event/src/localPointGeneric.ts
@@ -4,7 +4,7 @@ import { isSVGElement, isSVGGraphicsElement, isSVGSVGElement } from './typeGuard
 import getXAndYFromEvent from './getXAndYFromEvent';
 
 export default function localPoint(node: Element, event: EventType) {
-  if (!node || !event) return new Point({ x: 0, y: 0 });
+  if (!node || !event) return null;
 
   const coords = getXAndYFromEvent(event);