new(demo/xychart): add AreaStack, add stackOffset variable for stacks #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
williaster
commented
Jan 13, 2021
| @@ -720,6 +792,11 @@ export default function ExampleControls({ children }: ControlsProps) { | |||
| input[type='radio'] { | |||
| height: 10px; | |||
| } | |||
| .pattern-lines { | |||
There was a problem hiding this comment.
this pattern-only svg currently has a non-zero height on /xychart, this fixes it.
williaster
commented
Jan 13, 2021
| onChange={() => setRenderBarStackOrGroup('bar')} | ||
| onChange={() => { | ||
| if (renderAreaLineOrStack === 'areastack') { | ||
| setRenderAreaLineOrStack('none'); |
There was a problem hiding this comment.
previously I disabled updating renderAreaLineOrStack depending on the value of renderBarStackOrGroup, I think it's better UX if I just update the value of renderAreaLineOrStack so it's valid.
hshoff
approved these changes
Jan 15, 2021
williaster
force-pushed
the
chris--xychart-stacked-areas
branch
from
40c3855
to
eb30e36
Compare
williaster
force-pushed
the
chris--xychart-areastack-demo
branch
from
a078919
to
96284ef
Compare
Pull Request Test Coverage Report for Build 513505979
馃挍 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 Enhancements
This updates the
/xychartdemo to includeAreaStackadded in #1019 (see images there), and also adds a toggle forstackOffsetfor bothAreaStackandBarStack.@hshoff @kristw