fix(network): string type in node/linkComponent

[jraymakers]

Fixes #939

💥 Breaking Changes

• This changes the type signature of a public-facing prop, so it might be considered a breaking change. However, the type option that's being removed was broken anyway, so this doesn't break any functionality.

📝 Documentation

• Extended network example to show use of nodeComponent and linkComponent, as well as top and left props. Adapted from demo in comment of bug(network): string type is invalid for node/linkComponent #939

🐛 Bug Fix

• Remove string type from nodeComponent and linkComponent props in network package. This type was invalid in spite of being in the type signature. See bug(network): string type is invalid for node/linkComponent #939

[jraymakers]

I can't tell why Happo failed, because I can't follow the Detail link. (It says, "Sign in with your airbnb.com account to view this page.") But, it seems likely it's detecting the changes I made (intentionally) to the network gallery page.

[williaster]

Hey @jraymakers sorry for the delay, thanks for the fix! I agree this shouldn't be considered breaking since it was broken :)

We recently added happo and there are a couple of demos that are flaky, apologies for making you think you did something wrong and that you can't access the report. This is what it's reporting for your change:

It's a pretty big change aesthetically, I'm wondering if we could update the logic such that a single link is changed and a single node is changed. This would demonstrate the customizability and keep the aesthetics similar to before. It'd also be great to shift the bottom rectangle up to be visible in the gallery tile since it's clipped with the new y-offset.

[jraymakers]

Sure, that makes sense. I'll make the customizations more subtle.

[jraymakers]

@williaster I changed the example to just have one custom node and one custom link, and used styling that should fit in better with the defaults and the other gallery tiles. I also fixed the clipping issue.

As an added bonus, the example now shows how to use custom node and link types with this generic component.

[williaster]

@jraymakers amazing, it looks great! thanks for being open to iterating on styles 😄

Heads up I'm working on automating releases, I think this could be a good candidate for testing but it may take me a couple days to get it right.

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.5 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.6 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.7 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.8 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.9 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.10 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.11 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1-alpha.12 of the packages modified 🎉

[github-actions]

🎉 This PR is included in version v1.6.1 of the packages modified 🎉