internal: migrate off nimbus #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
changed the title
williaster
commented
Dec 16, 2022
| @@ -31,12 +31,12 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "babel": "yarn run babel:cjs && yarn run babel:esm", | |||
| "babel:cjs": "nimbus babel --clean --workspaces=\"@visx/!(demo)\"", | |||
| "babel:esm": "nimbus babel --clean --workspaces=\"@visx/!(demo)\" --esm", | |||
| "babel:cjs": "lerna exec --ignore @visx/demo --parallel -- babel --root-mode upward --delete-dir-on-start src/ --out-dir lib --extensions .ts,.tsx", | |||
There was a problem hiding this comment.
a big plus of nimbus was parallelization – prob have to use lerna for this
|
Just want to say thank you so much for doing something about this! |
williaster
commented
Dec 19, 2022
| root: true, | ||
| extends: [ | ||
| // these are relics of nimbus, we could definitely simplify + consolidate | ||
| './config-eslint/base.js', |
There was a problem hiding this comment.
this config is kind of out of control but I don't think trying to simplify it in this PR is a good idea given the amount of changes already here
ktmud
approved these changes
Dec 19, 2022
Size Changes
View raw build statsPrevious (master){
"visx-annotation": {
"esm": 33978,
"lib": 47235
},
"visx-axis": {
"esm": 21788,
"lib": 26480
},
"visx-bounds": {
"esm": 3301,
"lib": 3732
},
"visx-brush": {
"esm": 57656,
"lib": 61852
},
"visx-chord": {
"esm": 3486,
"lib": 4716
},
"visx-clip-path": {
"esm": 4502,
"lib": 6062
},
"visx-curve": {
"esm": 323,
"lib": 1464
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 12834,
"lib": 16829
},
"visx-event": {
"esm": 3807,
"lib": 5200
},
"visx-geo": {
"esm": 13425,
"lib": 16705
},
"visx-glyph": {
"esm": 15109,
"lib": 20013
},
"visx-gradient": {
"esm": 18135,
"lib": 22853
},
"visx-grid": {
"esm": 19171,
"lib": 23038
},
"visx-group": {
"esm": 1646,
"lib": 2274
},
"visx-heatmap": {
"esm": 7414,
"lib": 8770
},
"visx-hierarchy": {
"esm": 12209,
"lib": 18111
},
"visx-legend": {
"esm": 27079,
"lib": 34279
},
"visx-marker": {
"esm": 9101,
"lib": 11337
},
"visx-mock-data": {
"esm": 326069,
"lib": 329564
},
"visx-network": {
"esm": 4690,
"lib": 6869
},
"visx-pattern": {
"esm": 11826,
"lib": 15957
},
"visx-point": {
"esm": 1266,
"lib": 2095
},
"visx-react-spring": {
"esm": 13928,
"lib": 18860
},
"visx-responsive": {
"esm": 22582,
"lib": 27962
},
"visx-scale": {
"esm": 18512,
"lib": 30389
},
"visx-shape": {
"esm": 87327,
"lib": 109552
},
"visx-stats": {
"esm": 13830,
"lib": 15432
},
"visx-text": {
"esm": 8621,
"lib": 11351
},
"visx-threshold": {
"esm": 2911,
"lib": 3820
},
"visx-tooltip": {
"esm": 15808,
"lib": 24683
},
"visx-visx": {
"esm": 1524,
"lib": 4551
},
"visx-voronoi": {
"esm": 2313,
"lib": 3033
},
"visx-wordcloud": {
"esm": 2661,
"lib": 4673
},
"visx-xychart": {
"esm": 176957,
"lib": 251251
},
"visx-zoom": {
"esm": 16099,
"lib": 19179
}
}Current{
"visx-annotation": {
"esm": 33937,
"lib": 47074
},
"visx-axis": {
"esm": 21861,
"lib": 26466
},
"visx-bounds": {
"esm": 2948,
"lib": 3371
},
"visx-brush": {
"esm": 54136,
"lib": 58297
},
"visx-chord": {
"esm": 3478,
"lib": 4691
},
"visx-clip-path": {
"esm": 4524,
"lib": 6062
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 12756,
"lib": 14402
},
"visx-event": {
"esm": 3878,
"lib": 5194
},
"visx-geo": {
"esm": 13515,
"lib": 16741
},
"visx-glyph": {
"esm": 15177,
"lib": 19992
},
"visx-gradient": {
"esm": 18202,
"lib": 22847
},
"visx-grid": {
"esm": 18982,
"lib": 22665
},
"visx-group": {
"esm": 1648,
"lib": 2267
},
"visx-heatmap": {
"esm": 7394,
"lib": 8731
},
"visx-hierarchy": {
"esm": 12093,
"lib": 17910
},
"visx-legend": {
"esm": 26944,
"lib": 34024
},
"visx-marker": {
"esm": 9152,
"lib": 11350
},
"visx-mock-data": {
"esm": 326040,
"lib": 329480
},
"visx-network": {
"esm": 4674,
"lib": 6809
},
"visx-pattern": {
"esm": 11689,
"lib": 15763
},
"visx-point": {
"esm": 1003,
"lib": 1818
},
"visx-react-spring": {
"esm": 14000,
"lib": 17725
},
"visx-responsive": {
"esm": 20892,
"lib": 26221
},
"visx-scale": {
"esm": 18649,
"lib": 30334
},
"visx-shape": {
"esm": 86912,
"lib": 108820
},
"visx-stats": {
"esm": 13738,
"lib": 15320
},
"visx-text": {
"esm": 8567,
"lib": 10114
},
"visx-threshold": {
"esm": 2907,
"lib": 3806
},
"visx-tooltip": {
"esm": 14976,
"lib": 21474
},
"visx-visx": {
"esm": 1524,
"lib": 4487
},
"visx-voronoi": {
"esm": 2314,
"lib": 3021
},
"visx-wordcloud": {
"esm": 2620,
"lib": 3455
},
"visx-xychart": {
"esm": 177399,
"lib": 239197
},
"visx-zoom": {
"esm": 16077,
"lib": 19135
}
} |
|
Woot! Finally got CI to pass. Looked at the CI times and the TS task almost doubled because we lost some of the parallelization we got with nimbus. Everything else was mostly unchanged, though, and we can try to tune TS more in the future.
Edit: the new TS build time maybe isn't that different from the typical range. Here's another build with nimbus from today where the time here is the same as the non-nimbus build |
williaster
force-pushed
the
chris--bye-nimbus
branch
from
f96a9bf
to
d199498
Compare
|
🎉 This PR is included in version |
|
Great work @williaster ! You've saved the day! 🥇 🥳 |
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR migrates our development config / dependencies off of https://github.com/airbnb/nimbus which is no longer maintained and is more blackbox than we want.
Migrating off this will unblock things like #1578 and also allow us to upgrade beyond TS@3.8 which is the latest version
@airbnb/config-typescriptsupports.babel
@airbnb/config-babel+ add equivalent depsbuild:workspacesscript / update documentationeslint
@airbnb/config-eslint+ add equivalent deps--fixtypescript
@airbnb/config-typescript+ add equivalent depstsconfig*supdateReferencesscriptprettier
@airbnb/config-prettier+ add equivalent depsjsxBracketSameLineoptionjest
@airbnb/config-jest+ add equivalent depsremove
@airbnb/nimbusci passes 🎉 🍹
node>=16.10.0