fix(demo/sandboxes, xychart): Convert '@visx/.../src/...' to '@visx/.../lib/...' #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
changed the title
williaster
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Hey @SheaJanke thanks for the bug report and the fix here! I think there were some paths that were incorrectly updated tosrc/ during a major dev refactor at the end of 2022 that caused this.
lgtm!
|
Thanks for the review @williaster! Just a heads up that this also affects @visx/xychart, so maybe it should be added as a label as well. |
williaster
changed the title
|
oh yikes, thanks for the callout as that deserves a proper release. I am surprised that passed CI previously 馃槺 |
|
馃帀 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Bug Fix
import ... from '@visx/.../src/...';withimport ... from '@visx/.../lib/...';