fix: vendor esm-only packages #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2023
Merged
Size Changes
View raw build statsPrevious (master){
"visx-annotation": {
"esm": 31002,
"lib": 43431
},
"visx-axis": {
"esm": 21699,
"lib": 26304
},
"visx-bounds": {
"esm": 2948,
"lib": 3371
},
"visx-brush": {
"esm": 54136,
"lib": 58297
},
"visx-chord": {
"esm": 3478,
"lib": 4691
},
"visx-clip-path": {
"esm": 4524,
"lib": 6062
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-demo": {
"esm": 0,
"lib": 36504
},
"visx-drag": {
"esm": 12756,
"lib": 14402
},
"visx-event": {
"esm": 3878,
"lib": 5194
},
"visx-geo": {
"esm": 13515,
"lib": 16741
},
"visx-glyph": {
"esm": 15177,
"lib": 19992
},
"visx-gradient": {
"esm": 18202,
"lib": 22847
},
"visx-grid": {
"esm": 18982,
"lib": 22665
},
"visx-group": {
"esm": 1648,
"lib": 2267
},
"visx-heatmap": {
"esm": 7394,
"lib": 8731
},
"visx-hierarchy": {
"esm": 12093,
"lib": 17910
},
"visx-legend": {
"esm": 26944,
"lib": 34024
},
"visx-marker": {
"esm": 9152,
"lib": 11350
},
"visx-mock-data": {
"esm": 326040,
"lib": 329480
},
"visx-network": {
"esm": 4674,
"lib": 6809
},
"visx-pattern": {
"esm": 11689,
"lib": 15763
},
"visx-point": {
"esm": 1003,
"lib": 1818
},
"visx-react-spring": {
"esm": 14000,
"lib": 17725
},
"visx-responsive": {
"esm": 12972,
"lib": 16175
},
"visx-scale": {
"esm": 18649,
"lib": 30334
},
"visx-shape": {
"esm": 86912,
"lib": 108820
},
"visx-stats": {
"esm": 13738,
"lib": 15320
},
"visx-text": {
"esm": 8567,
"lib": 10114
},
"visx-threshold": {
"esm": 2907,
"lib": 3806
},
"visx-tooltip": {
"esm": 15233,
"lib": 21734
},
"visx-visx": {
"esm": 1524,
"lib": 4487
},
"visx-voronoi": {
"esm": 2314,
"lib": 3021
},
"visx-wordcloud": {
"esm": 2620,
"lib": 3455
},
"visx-xychart": {
"esm": 178152,
"lib": 239950
},
"visx-zoom": {
"esm": 16239,
"lib": 19297
}
}Current{
"visx-annotation": {
"esm": 31002,
"lib": 43431
},
"visx-axis": {
"esm": 21699,
"lib": 26304
},
"visx-bounds": {
"esm": 2948,
"lib": 3371
},
"visx-brush": {
"esm": 54136,
"lib": 58297
},
"visx-chord": {
"esm": 3478,
"lib": 4691
},
"visx-clip-path": {
"esm": 4524,
"lib": 6062
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-demo": {
"esm": 0,
"lib": 36517
},
"visx-drag": {
"esm": 12756,
"lib": 14402
},
"visx-event": {
"esm": 3878,
"lib": 5194
},
"visx-geo": {
"esm": 13515,
"lib": 16741
},
"visx-glyph": {
"esm": 15177,
"lib": 19992
},
"visx-gradient": {
"esm": 18202,
"lib": 22847
},
"visx-grid": {
"esm": 18982,
"lib": 22665
},
"visx-group": {
"esm": 1648,
"lib": 2267
},
"visx-heatmap": {
"esm": 7394,
"lib": 8731
},
"visx-hierarchy": {
"esm": 12093,
"lib": 17910
},
"visx-legend": {
"esm": 26944,
"lib": 34024
},
"visx-marker": {
"esm": 9152,
"lib": 11350
},
"visx-mock-data": {
"esm": 326040,
"lib": 329480
},
"visx-network": {
"esm": 4674,
"lib": 6809
},
"visx-pattern": {
"esm": 11689,
"lib": 15763
},
"visx-point": {
"esm": 1003,
"lib": 1818
},
"visx-react-spring": {
"esm": 14000,
"lib": 17725
},
"visx-responsive": {
"esm": 12972,
"lib": 16175
},
"visx-scale": {
"esm": 18870,
"lib": 30555
},
"visx-shape": {
"esm": 86912,
"lib": 108820
},
"visx-stats": {
"esm": 13738,
"lib": 15320
},
"visx-text": {
"esm": 8567,
"lib": 10114
},
"visx-threshold": {
"esm": 2907,
"lib": 3806
},
"visx-tooltip": {
"esm": 15233,
"lib": 21734
},
"visx-vendor": {
"esm": 2002,
"lib": 2170
},
"visx-visx": {
"esm": 1524,
"lib": 4487
},
"visx-voronoi": {
"esm": 2314,
"lib": 3021
},
"visx-wordcloud": {
"esm": 2620,
"lib": 3455
},
"visx-xychart": {
"esm": 178204,
"lib": 240002
},
"visx-zoom": {
"esm": 16239,
"lib": 19297
}
} |
* vendor: add working transpilation scripts * vendor: update readme * vendor: fix package.json conflicts * vendor: add remaining packages * vendor: tweak type exports * vendor: fix type and index generation * vendor: fix relative path generation * vendor: add tests for all vendored packages * vendor: use yarn nohoist instead of npm aliases
* scale: point to vendor package * demo: remove next-transpile-modules * demo: point to vendor package * scale: point to vendor package (again) * xychart: point to vendor package * scale: point to vendor package (again) * update yarn.lock * deps: try lerna@7 * types: update ts refs * fix things to fully build * vendor: add tsconfig note * demo: name Show function to silence warning * vendor: fix conditional exports and types export * demo: add NoSsr component * vendor: remove internmap types export * vendor: internmap fix again
* vendor: add scripts/flagVendorRequirements * vendor: tweak esm map * github: add vendor-check to PR workflow
williaster
force-pushed
the
chrisw--d3-fix
branch
from
0e59c02
to
ae6a22e
Compare
|
🎉 This PR is included in version |
|
🎉 This PR is included in version |
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP umbrella branch to fix
@visx/scalehas an incorrect package.json that always resolve to cjs file #1653Generally our approach will be similar to
VictoryVendor, where we will vendor and re-export anyesm-only dependencies we have as CJS + ESM, to continue to support both types. I don't believe it's feasible to simply referencevictory-vendorbecause they don't vendor all d3 ESM-only packages (sincevisxis more low-level, we reference more esotericd3packages e.g.,d3-chord)Will PR into this branch to break up the changes for easier review and tracking
@visx/*packages to point to@visx/vendorwhere necessary, remove ESM-only handling in@visx/demorefactor: point to @visx/vendor #1719update allvisx*: adopt conditional exports #1721@visx/*packages to adopt conditional exports