Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xychart): Cleanup async function in TooltipProvider #1728

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

SheaJanke
Copy link
Contributor

🐛 Bug Fix

  • Cleanup the debouncedHideTooltip function in the TooltipProvider component when it unmounts.

closes: #1726

* Clean up the debouncedHideTooltip function in the TooltipProvider
  when the component unmounts so we no longer get "Can't perform a
  React state update on an unmounted component" warnings.
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thanks for the fix @SheaJanke! 🙏

@williaster williaster merged commit f537dee into airbnb:master Jul 6, 2023
2 checks passed
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🎉 This PR is included in version v3.2.1 of the packages modified 🎉

@SheaJanke SheaJanke deleted the fix-hide-tooltip branch July 6, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XYChart TooltipProvider: "Can't perform a React state update on an unmounted component."
2 participants