feat(brush): disable drag overlay

[Onxi95]

Hi! Thank you for this wonderful library - without you I would probably cry in the corner thinking how to implement fancy charts 😅

🚀 Enhancements

• added disableDraggingOverlay to Brush in order to be able to use Brush only as a scroll (without possibility of changing its size)

🤔 Motivation

I was building something similar to bar chart. The requirements changed a bit (ofc 😅) and the chart has to have multiple columns with minimum width and scrollbar if needed. The closest solution to achieve this result is Brush (It doesn't handle scroll events, but manual scroll using mouse is good enough for our use-case).
I styled the brush to look like a standard, gray scrollbar, but when I click outside of it, new area of brush is created. There's disableDraggingSelection prop, but it affects scrollbar, and there's no option to do something similar but to overlay. I managed to work around it by using pointer-events: none, but I think it's a bit hacky solution and making it available in the lib might be beneficial :D

🧪 How to test it?

in brush example (packages/visx-demo/src/sandboxes/visx-brush/Example.tsx), adjust <Brush /> component like:

          <Brush
            xScale={brushDateScale}
            yScale={brushStockScale}
            disableDraggingOverlay // <- new prop
            width={xBrushMax}
            height={yBrushMax}
            margin={brushMargin}
            // handleSize={8}
            innerRef={brushRef}
            // resizeTriggerAreas={['left', 'right']}
            brushDirection="horizontal"
            initialBrushPosition={initialBrushPosition}
            onChange={onBrushChange}
            // onClick={() => setFilteredStock(stock)}
            selectedBoxStyle={selectedBrushStyle}
            useWindowMoveEvents
            // renderBrushHandle={(props) => <BrushHandle {...props} />}
          />

brush.mp4

[Onxi95]

Hi @williaster 👋 Can you take a look at it when you have some time? 😄

[williaster]

Hi @Onxi95 👋 thanks for the ping, sorry this slipped through. It looks like CI hasn't run for the PR, can you try to rebase just to re-trigger things? I'll try to take a look at it ASAP, it may be next week due to the holiday this week

[Onxi95]

Hello @williaster 👋

I was looking around, trying to see what's going on with actions, but at the end I saw that

1 workflow awaiting approval

I guess it's needed to trigger actions and I think I don't have permissions to do it 😅

Launched the jobs from pull_request.yml (skipped yarn run happo-ci-github-actions & had some issues with yarn check:sizes as it relies on getGithubClient function that uses some CI envs) locally and I didn't see any issues - if I miss something, please let me know 🙏

[williaster]

Thanks for your patience here @Onxi95 🙏 this lgtm, thank you for the contribution!

[github-actions]

🎉 This PR is included in version v3.6.0 of the packages modified 🎉