-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(axis): Expose innerRef prop on the various Axis components #1749
Conversation
@williaster if you have some time can you have a look at this please? It's a pretty simple change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SheaJanke sorry I was on vacation for a couple of weeks and am just catching up. This lgtm! As always, thank you for the contribution 🙌
@@ -215,4 +216,15 @@ describe('<Axis />', () => { | |||
expect(points.at(2).prop('from')).toEqual({ x: 10.5, y: 0 }); | |||
expect(points.at(2).prop('to')).toEqual({ x: 0.5, y: 0 }); | |||
}); | |||
|
|||
test('should expose its ref via an innerRef prop', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much for adding tests 🙏 💯
🎉 This PR is included in version |
…nb#1749) * feat(axis): Expose innerRef prop on the Axis component * feat(axis): Improve documentation for the innerRef prop * feat(axis): Remove unnecessary import * feat(axis): Retrigger build
🚀 Enhancements
Axis
components. This makes it possible to get the dimensions of the of theAxis
without usinggetStringWidth
on all the tick values.closes: #1086