visx-axis AxisRenderer.tsx: resolve circular dependency #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Hey @ithrforu thanks for looking into this and for contributing the fix! Really appreciate the detailed logs/context 🙏
Will get this in once CI finishes 🚀
|
@williaster, thanks for the feedback! The |
|
@ithrforu resolved! |
|
🎉 This PR is included in version |
Onxi95
pushed a commit
to Onxi95/visx
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
Resolve circular dependencies in packages/visx-axis/src/axis.
Neighboring files (Axis.tsx#10, AxisBottom.tsx#4, AxisLeft.tsx#4 etc.) import the
Orientationconstant from../constants/orientation, but for some reasonAxisRenderer.tsximportOrientationfrom the public API (../index.ts). This is the cause of circular dependencies.Before (webpack's circular-dependency-plugin):
After:
There are no circular dependencies in
@visx/axis.